use max_cores in taskQueue instead of system cores #2038
Conversation
The class TascQueue accepts an argument `thread_count` that is used for the max size of a queue. In the `MultithreadedJobExecutor `class there is a variable defined (`max_cores`) that is getting its value from the available cores of the machine. Further down in the same class when TaskQueue is called instead of using the `max_cores` it is using `psutil.cpu_count()`. I suggest to use the self.max_cores in the call of TaskQueue in the file executor.py instead of psutil.cpu_count() Use case: when a job executor is setup as MultithreadedJobExecutor one can override the max_cores after the initialization of the object and limit the use to the specified cores. Additional enhancement would be to include an argument to allow the use to provide the number of cores available for use
Update executors.py
|
Hello, is there any update on this? |
|
hi @kmavrommatis, I'm taking a look at it. It should already be the case that it will not start more than On the other hand if you want to start more than That said, it would be a useful feature to add command line options like |
|
Hi @tetron |
|
@kmavrommatis just to confirm, are you requesting a fractional core in your CWL file? e.g. |
The class
TascQueueaccepts an argumentthread_countthat is used for the max size of a queue.In the MultithreadedJobExecutor class there is a variable defined (
max_cores) that is getting its value from the available cores of the machine. Further in the same class when TaskQueue is called instead of using the max_cores it is usingpsutil.cpu_count().I propose to use the
max_coresvariable when initializing the TaskQueue.Use case. one can override the max_cores in the MutlithreadedJobExecutor after initialization and force cwltool to use only up to a certain number of cores.